Skip to content

Skip logging when the count is zero#2560

Merged
jeremydmiller merged 1 commit intoJasperFx:mainfrom
Bishbulb:fix/ravendb-durability-recovery-log-noise
Apr 26, 2026
Merged

Skip logging when the count is zero#2560
jeremydmiller merged 1 commit intoJasperFx:mainfrom
Bishbulb:fix/ravendb-durability-recovery-log-noise

Conversation

@Bishbulb
Copy link
Copy Markdown
Contributor

Summary

Per our quick discussion in Discord, gating the durability agent's recovery logs behind count > 0 so an idle app doesn't emit Recovered 0 incoming envelopes or Successfully recovered 0 messages every poll cycle.

Changes

  • TransportLoggerExtensions.RecoveredIncoming and RecoveredOutgoing early return when count is zero
    • These helpers are called by every persistence provider, but I still suggest it makes sense to avoid logging zeroes here
  • RavenDbDurabilityAgent.Incoming.cs and RavenDbDurabilityAgent.Outgoing.cs
    • Avoid logging when the count is zero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants